Storing CF API token data in domain config #5018
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2398
This PR changes the storage location of Cloudflare's
API Token
,Account ID
andZone ID
from account config to domain config.For now, to save these vars to domain config we need to set
Zone ID
, otherwise the vars will be stored to account (global) config:acme.sh/dnsapi/dns_cf.sh
Lines 28 to 37 in aa8cf76
This makes it impossible to handle miltiple zones (using
Account ID
instead ofZone ID
) from multiple Cloudflare accounts on the same server: we can't have different values ofAPI Token
andAccount ID
in account config.