Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for empty error objects in response breaking extraction of domain validation types #5008

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Commits on Feb 3, 2024

  1. Configuration menu
    Copy the full SHA
    160b2e9 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Configuration menu
    Copy the full SHA
    de14d59 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Fix for empty error objects in response breaking extraction of domain…

    … validation types
    
    Fix for empty error objects in the response which mess up the extraction of domain validation types due to the closing brace in the error object prematurely matching the end of the search pattern.
    
    This seems to be a recent change with ZeroSSL in particular where "error":{} is being included in responses.
    
    There could potentially be a related issue if there is a complex error object ever returned in the validation check response where an embedded sub-object could lead to an incomplete extraction of the error message, roughly around line 5040.
    
    Adapted from fix suggested here: acmesh-official#4933 (comment)
    cjwalsh committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b0ca443 View commit details
    Browse the repository at this point in the history