This repository has been archived by the owner on Sep 18, 2022. It is now read-only.
Verify ssl cert #12
Closed
Verify ssl cert #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps our communication from being tampered with from man in the middle attacks. We want to verify the SSL certificate of the API, basically always.
To match the style in Shodan class including explicitly setting the verification mode to VERIFY_PEER to prevent man in the middle attacks.
|
@achillean 馃悰 |
|
@achillean 馃 |
|
@achillean 鉂わ笍 |
|
@achillean 鈽庯笍 ? Maybe archiving this project? |
|
Sorry, yes this project should probably get archived. We actually don't link to this project anymore on the developer website. Instead, we refer to the excellent https://github.com/picatz/shodanz gem developed by @picatz |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed last night that this gem had the peculiar
OpenSSL::SSL::VERIFY_NONEverification mode when making requests to the Shodan API. This mode doesn't perform any verification.This can leave communication susceptible to man in the middle attacks, which I'm sure we'd much rather avoid. So I've explicitly changed that to
OpenSSL::SSL::VERIFY_PEERto verify our peer.This PR should have no real effect on the typical usage of this gem, other than making it safer. 馃憤