-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] ability to add note at the top of form when creating a task #1333
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not totally sure of code but works as expected on my local install
|
||
<% if input_notes.any? %> | ||
</div> | ||
<% end %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why errors is subdiv of notes div
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong. Sergiy is right to be suspicious. If you have to put a </div>
inside an if
it certainly means the layout structure is badly done.
Also, this file here is a template for the general params page of all tasks, it cannot possibly have any sort of knownlede or dependencies on things like @task.descriptor_for_before_form
which are compltely internal to the new BTQ integrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-think the whole thing, see my comments
Close #1025.
To test if please add (or not) the following on a Boutiques descriptor (in custom section):
It works for bot Boutiques integrato old and new.