Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] ability to add note at the top of form when creating a task #1333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

natacha-beck
Copy link
Contributor

Close #1025.

To test if please add (or not) the following on a Boutiques descriptor (in custom section):

        "cbrain:input_notes": [
            "Note 1: this is the first note",
            "Note 2: this is the  note"
        ],

It works for bot Boutiques integrato old and new.

@natacha-beck natacha-beck added Enhancement Boutiques Boutiques integration labels May 15, 2023
@natacha-beck natacha-beck self-assigned this May 15, 2023
@MontrealSergiy
Copy link
Contributor

works on my local install (new boutiques)

Screenshot from 2023-05-31 14-27-46

Copy link
Contributor

@MontrealSergiy MontrealSergiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not totally sure of code but works as expected on my local install


<% if input_notes.any? %>
</div>
<% end %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why errors is subdiv of notes div

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. Sergiy is right to be suspicious. If you have to put a </div> inside an if it certainly means the layout structure is badly done.

Also, this file here is a template for the general params page of all tasks, it cannot possibly have any sort of knownlede or dependencies on things like @task.descriptor_for_before_form which are compltely internal to the new BTQ integrator.

Copy link
Member

@prioux prioux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-think the whole thing, see my comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Boutiques Boutiques integration Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for notes-for-users in the custom section of Boutiques descriptor
3 participants