[ADD] launching task arrays by selecting multiple files in New Boutiques #1298
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
natacha-beck
force-pushed
the
boutiques_multiple_tasks
branch
from
2c78795
to
bfc34f8
Compare
…ith new BTQ integrator
natacha-beck
force-pushed
the
boutiques_multiple_tasks
branch
from
8e7b495
to
cad474a
Compare
| @@ -522,21 +523,27 @@ def sanitize_param(input) | |||
| # Make sure the file ID is valid, accessible, not already used and | |||
| # of the correct type. | |||
| when :file | |||
| unless (Integer(value) rescue nil) | |||
| if !(Integer(value) rescue nil) && !single_file_input? | |||
There was a problem hiding this comment.
I don't understand why the fact we have a single file input is important when validating that a file's value is an integer? It shoudl always be validated, no?
|
I will need to review this carefully, just a read of the code is not enough for me to approve it. The changes are too complex and subtle. |
There was a problem hiding this comment.
I think this entire change set is wrong. The code modified here is mostly in the method sanitize_params(), which is a validation method, not a method supposed to actually perform behavioral actions like assigning input files. It's just supposed to verify them.
Please reconsider the whole thing, it's sanitize_params is not the right place to implement this feaure.
| file = Userfile.find_accessible_by_user(value, self.user, :access_requested => file_access_symbol()) rescue nil | ||
| unless file | ||
| params_errors.add(invokename, ": cannot find userfile (ID #{value})") | ||
| file_ids = value.blank? ? self.params[:interface_userfile_ids] : [value] |
There was a problem hiding this comment.
This is a list of userfile IDs [ 1, 2, 3 ]....
| unless file | ||
| params_errors.add(invokename, ": cannot find userfile (ID #{value})") | ||
| file_ids = value.blank? ? self.params[:interface_userfile_ids] : [value] | ||
| file_ids = Userfile.find_all_accessible_by_user( self.user, |
There was a problem hiding this comment.
And not this is a list of PAIRS, ids and names [ [ 1, 'hello' ], [ 2, 'bye' ] ]
Why is that variable still called file_ids ?
| :access_requested => file_access_symbol | ||
| ).where(:id => file_ids).pluck(:id, :name) rescue nil | ||
|
|
||
| if !file_ids.present? |
Closed #1201