Group license 1244 #1268
Open
Group license 1244 #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| userfile.sync_to_cache | ||
| @license_text = userfile.cache_readhandle { |fh| fh.read } | ||
|
|
||
| # Identifies if the current user has already signed it, |
There was a problem hiding this comment.
Should be removed too ?
There was a problem hiding this comment.
what do you want to remove comment # Identifies if the current user has already signed it,
that's for class variables, verbatim copy of the same comment Pierre made (or merged in) in a Neurohub controller, but confirm if you find it redundand
8 tasks
|
addressed all @natacha-beck comment that I understood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds project licenses to cbrain see #1244
Note I am not sure of license deletion process (as exists in Neurohub), to be investigated latter, seems improvized