Fix unused vars eslint warnings #9226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix errors unused-vars warnings that are easily fixed errors. I'm not sure of the impact of changing the remaining two since they're used in a destructuring context. Someone familiar with the EEG browser should fix (and test) them. Upgrade rule from "warning" to "error" for javascript, while leaving it for typescript since there are two that are still unresolved.
driusan
added
Cleanup
MaximeMulder
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors unused-vars warnings that are easily fixed errors. I'm not sure of the impact of changing the remaining two since they're used in a destructuring context. Someone familiar with the EEG browser should fix (and test) them.
Upgrade rule from "warning" to "error" for javascript, while leaving it for typescript since there are two that are still unresolved.