Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[genomic_browser] Minor edits to the test plan #9198

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[genomic_browser] Minor edits to the test plan #9198

merged 2 commits into from
Apr 23, 2024

Conversation

nicolasbrossard
Copy link
Contributor

@nicolasbrossard nicolasbrossard commented Apr 9, 2024 •
edited

This PR modifies the test plan for the genomic browser module. The changes are mostly cosmetics but also include corrections of the permission names and table headers mentioned in the plan.

Fixes #9151

@nicolasbrossard nicolasbrossard added Testing PR contains test plan or automated test code (or config files for Travis) 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 labels Apr 9, 2024
@nicolasbrossard nicolasbrossard mentioned this pull request Apr 9, 2024
Closed
@driusan
Copy link
Collaborator

driusan commented Apr 9, 2024

@christinerogers can you review this?

christinerogers
christinerogers approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@christinerogers christinerogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes all look fine to me -- will try to fix a typo found, but that shouldn't hold up merge.

modules/genomic_browser/test/TestPlan.md Outdated Show resolved Hide resolved
@christinerogers
Copy link
Contributor

@driusan I think this is ready to merge ( including latest typo fix commit)

@driusan driusan merged commit 7eafeef into aces:main Apr 23, 2024
28 checks passed
@christinerogers christinerogers removed their assignment May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinerogers christinerogers christinerogers approved these changes

Assignees
No one assigned
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Testing PR contains test plan or automated test code (or config files for Travis)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[genomic_browser] Test plan needs minor corrections
3 participants
@nicolasbrossard @driusan @christinerogers