-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examiner] Adds permission check when adding examiner to site. #9188
Merged
driusan
merged 10 commits into
aces:main
from
racostas:2024_04_02_examiner_adds_permission_check_when_adding_examiner_to_site
Apr 24, 2024
Merged
[examiner] Adds permission check when adding examiner to site. #9188
driusan
merged 10 commits into
aces:main
from
racostas:2024_04_02_examiner_adds_permission_check_when_adding_examiner_to_site
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racostas
added
the
"Help! I don't understand Travis!"
PR is having a beef with TRAVIS. Someone needs to help
label
Apr 2, 2024
…xaminer_to_site' of https://github.com/racostas/Loris into 2024_04_02_examiner_adds_permission_check_when_adding_examiner_to_site
…xaminer_to_site' of https://github.com/racostas/Loris into 2024_04_02_examiner_adds_permission_check_when_adding_examiner_to_site
…xaminer_to_site' of https://github.com/racostas/Loris into 2024_04_02_examiner_adds_permission_check_when_adding_examiner_to_site
racostas
removed
the
"Help! I don't understand Travis!"
PR is having a beef with TRAVIS. Someone needs to help
label
Apr 2, 2024
sruthymathew123
added
the
Passed Manual Tests
PR has undergone proper testing by at least one peer
label
Apr 18, 2024
@driusan Tested and looks good on my end. |
driusan
reviewed
Apr 19, 2024
driusan
reviewed
Apr 19, 2024
racostas
force-pushed
the
2024_04_02_examiner_adds_permission_check_when_adding_examiner_to_site
branch
from
April 24, 2024 14:54
77cd3ff
to
c13c615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Permissions are check now before allowing to add examiner to site.
Before this PR, a user with only the permission
Examiner: Add and Certify Examiners - Own Sites
was able to add examiners to sites it don't belongs to. Now this feature is only granted to users with the corresponding level of permission.Testing instructions (if applicable)
Examiner: Add and Certify Examiners - Own Sites
try to create a new examiner inMainMenu->Clinical->Examinier
Link(s) to related issue(s)