Remove lorispath from PSR7 request #9055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeMulder
commented
Feb 14, 2024
Comment on lines
+50
to
+57
| $query = implode( | ||
| "&", | ||
| array_map( | ||
| fn ($key, $value) => $key . "=" . $value, | ||
| array_keys($params), | ||
| $params | ||
| ) | ||
| ); |
There was a problem hiding this comment.
I did not use http_build_query because the parameters should already be URL-encoded.
There was a problem hiding this comment.
Is this necessary? Shouldn't it have been handled internally by the library after $serverrequest = $serverrequest->withQueryParams($params);?
There was a problem hiding this comment.
Is this necessary? Shouldn't it have been handled internally by the library after
$serverrequest = $serverrequest->withQueryParams($params);?
Yes it is, the request stores both the query parameters as an array and as a string in the URI. Changing one does not affect the other.
driusan
reviewed
Feb 14, 2024
htdocs/index.php
Outdated
| // Remove the lorispath from the URI query parameters. | ||
| // Both the request query parameters and the URI query string must be updated. | ||
| $params = $serverrequest->getQueryParams(); | ||
| $params = array_diff_key($params, ["lorispath" => null]); |
There was a problem hiding this comment.
Suggested change
| $params = array_diff_key($params, ["lorispath" => null]); | |
| unset($params['lorispath']); |
There was a problem hiding this comment.
TIL PHP arrays are copy-on-write.
Applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Removes
lorispathfrom the PSR7 request's query parameters and uri query string (both must be updated separately).Manipulating arrays in PHP is so verbose 馃槾.
Testing instructions
var dump
$serverrequestLinks to related issues