New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace DoB/EDC with 'Derived Age'/'EDC Age' #8990
base: main
Are you sure you want to change the base?
Conversation
@GeorgeMurad please try to replace '90000' to '300001' in /test/test_instrument/test_instrumentTest.php. |
@GeorgeMurad https://github.com/aces/Loris/blob/main/modules/candidate_profile/test/candidate_profileTest.php line 100 and line 123 90000 to 300001 |
@GeorgeMurad please revert all change '90000' to '300001' in /test/test_instrument/test_instrumentTest.php. |
@kongtiaowang I did replace all 900000 to 300001 in /test/test_instrument/test_instrumentTest.php. |
@GeorgeMurad |
[client 192.168.122.1:47966] [CRITICAL] /var/www/loris/modules/instrument_list/php/instrument_list.class.inc:307: Uncaught TypeError: strtotime(): Argument #1 ($datetime) must be of type string, null given in /var/www/loris/modules/instrument_list/php/instrument_list.class.inc:307\nStack trace:\n#0 /var/www/loris/modules/instrument_list/php/instrument_list.class.inc(307): strtotime()\n#1 /var/www/loris/php/libraries/NDB_Page.class.inc(741): LORIS\instrument_list\Instrument_List->setup()\n#2 /var/www/loris/src/Middleware/UserPageDecorationMiddleware.php(247): NDB_Page->handle()\n#3 /var/www/loris/src/Middleware/PageDecorationMiddleware.php(58): LORIS\Middleware\UserPageDecorationMiddleware->process()\n#4 /var/www/loris/php/libraries/NDB_Page.class.inc(725): LORIS\Middleware\PageDecorationMiddleware->process()\n#5 /var/www/loris/modules/instrument_list/php/instrument_list.class.inc(154): NDB_Page->process()\n#6 /var/www/loris/php/libraries/Module.class.inc(321): LORIS\instrument_list\Instrument_List->process()\n#7 /var/www/loris/modules/instrument_list/php/module.class.inc(46): Module->handle()\n#8 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\instrument_list\Module->handle()\n#9 /var/www/loris/src/Middleware/AuthMiddleware.php(63): LORIS\Middleware\ResponseGenerator->process()\n#10 /var/www/loris/src/Router/ModuleRouter.php(74): LORIS\Middleware\AuthMiddleware->process()\n#11 /var/www/loris/src/Middleware/ExceptionHandlingMiddleware.php(54): LORIS\Router\ModuleRouter->handle()\n#12 /var/www/loris/src/Router/BaseRouter.php(132): LORIS\Middleware\ExceptionHandlingMiddleware->process()\n#13 /var/www/loris/src/Middleware/ResponseGenerator.php(50): LORIS\Router\BaseRouter->handle()\n#14 /var/www/loris/src/Middleware/ContentLength.php(52): LORIS\Middleware\ResponseGenerator->process()\n#15 /var/www/loris/htdocs/index.php(55): LORIS\Middleware\ContentLength->process()\n#16 {main}\n thrown, referer: https://test-dev-250.loris.ca/288206/ |
43323c8
to
0736b50
Compare
--- a/test/test_instrument/test_instrumentTest.php |
d4a15a7
to
67284b1
Compare
81885ce
to
adcd615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double 128 in RB config file
@GeorgeMurad |
cb790e0
to
3131c21
Compare
@GeorgeMurad I have modified the files. Could you please perform the manual test to confirm that the changes are correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Brief summary of changes
Testing instructions (if applicable)
Link(s) to related issue(s)