-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Parent Portal] from IBIS #7050
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good so far! some minor changes, and one big one (how PatientIDs are generated). I also think that as part of this PR, we should hide the 'Email' column of surveyAccountsIndex but keep it filterable (because emails can potentially be identifying information)
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
to restart Travis |
remove space
I don't understand the reasoning behind reactifying the parent portal.. isn't the parent portal for subjects doing data entry on their own computer? How do you know they haven't disabled javascript or installed some other plugin that will interfere with this? Plain HTML seems like it would be much safer. |
hey @driusan the parent portal isn't actually used for data entry, thats the new survey module. the parent portal is essentially just a table listing the surveys the parents can fill out, with links to the survey. i don't see an issue with this module being reactified, especially given that we're reactifiying all of loris, i don't see why we would leave this module out. also, the new survey module that IBIS and QPN are using is reactified so the ship has kind of already sailed on that. I just feel like we may be creating double work if we review and test this PR as plain html, to only then reactify it in the future. when we can just accept the already reactified code now. what do you think? |
rebase |
This PR is out of date. |
replace by participant portal |
Brief summary of changes
add the parent portal form IBIS
Testing instructions (if applicable)
Add a new candidate, then create an instrument for this new user.
Go to survey account module, click the parentID link to load this module.