Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parent Portal] from IBIS #7050

Closed
wants to merge 37 commits into from
Closed

Conversation

kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Sep 21, 2020

Brief summary of changes

add the parent portal form IBIS

Testing instructions (if applicable)

Sep-17-2020 13-19-09

Add a new candidate, then create an instrument for this new user.
Go to survey account module, click the parentID link to load this module.

@kongtiaowang kongtiaowang added the Feature PR or issue introducing/requiring at least one new feature label Sep 21, 2020
@zaliqarosli zaliqarosli self-assigned this Sep 21, 2020
Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good so far! some minor changes, and one big one (how PatientIDs are generated). I also think that as part of this PR, we should hide the 'Email' column of surveyAccountsIndex but keep it filterable (because emails can potentially be identifying information)

SQL/0000-00-00-schema.sql Outdated Show resolved Hide resolved
modules/parent_portal/jsx/ParentPortalIndex.js Outdated Show resolved Hide resolved
modules/parent_portal/jsx/ParentPortalIndex.js Outdated Show resolved Hide resolved
modules/parent_portal/php/survey_handle.class.inc Outdated Show resolved Hide resolved
modules/parent_portal/php/survey_handle.class.inc Outdated Show resolved Hide resolved
modules/parent_portal/php/survey_handle.class.inc Outdated Show resolved Hide resolved
php/libraries/Candidate.class.inc Outdated Show resolved Hide resolved
php/libraries/Candidate.class.inc Outdated Show resolved Hide resolved
php/libraries/Candidate.class.inc Outdated Show resolved Hide resolved
php/libraries/Candidate.class.inc Outdated Show resolved Hide resolved
@kongtiaowang kongtiaowang added the Blocked PR awaiting the merge, resolution or rejection of an other Pull Request label Oct 29, 2020
@kongtiaowang kongtiaowang changed the base branch from main to 23.0-release November 4, 2020 17:24
@kongtiaowang kongtiaowang changed the base branch from 23.0-release to main November 4, 2020 17:24
@kongtiaowang
Copy link
Contributor Author

to restart Travis

@kongtiaowang kongtiaowang reopened this Nov 4, 2020
php/libraries/Candidate.class.inc Outdated Show resolved Hide resolved
php/libraries/ParentIDGenerator.php Outdated Show resolved Hide resolved
php/libraries/ParentIDGenerator.php Outdated Show resolved Hide resolved
php/libraries/ParentIDGenerator.php Outdated Show resolved Hide resolved
@driusan
Copy link
Collaborator

driusan commented Dec 15, 2020

I don't understand the reasoning behind reactifying the parent portal.. isn't the parent portal for subjects doing data entry on their own computer? How do you know they haven't disabled javascript or installed some other plugin that will interfere with this? Plain HTML seems like it would be much safer.

@kongtiaowang kongtiaowang changed the title Reactify [Parent Portal] from IBIS [Parent Portal] from IBIS Jan 4, 2021
@zaliqarosli
Copy link
Contributor

zaliqarosli commented Jan 5, 2021

hey @driusan the parent portal isn't actually used for data entry, thats the new survey module. the parent portal is essentially just a table listing the surveys the parents can fill out, with links to the survey. i don't see an issue with this module being reactified, especially given that we're reactifiying all of loris, i don't see why we would leave this module out. also, the new survey module that IBIS and QPN are using is reactified so the ship has kind of already sailed on that.

I just feel like we may be creating double work if we review and test this PR as plain html, to only then reactify it in the future. when we can just accept the already reactified code now. what do you think?

@kongtiaowang
Copy link
Contributor Author

rebase

@kongtiaowang kongtiaowang reopened this Mar 12, 2021
@kongtiaowang
Copy link
Contributor Author

This PR is out of date.

@kongtiaowang kongtiaowang reopened this Feb 8, 2024
@kongtiaowang kongtiaowang added Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix and removed Feature PR or issue introducing/requiring at least one new feature labels Feb 8, 2024
@kongtiaowang
Copy link
Contributor Author

replace by participant portal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants