Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo - Add documentation on adding cargo via config #9994

Merged
merged 4 commits into from
May 22, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 28, 2024

When merged this pull request will:

  • Title.
  • Minor cleanup.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/change Release Notes: **CHANGED:** label Apr 28, 2024
@Drofseh
Copy link
Contributor

Drofseh commented May 9, 2024

I'm not sure it's a good idea to reduce the avaiable cargo space of a vehicle this late in the game. Likewise for increasing the cargo size of vehicle.
It could screw up existing mission by preventing their cargo from fitting.

@johnb432
Copy link
Contributor Author

johnb432 commented May 9, 2024

It could screw up existing mission by preventing their cargo from fitting.

Whilst I do agree, being able to fit a same sized object within an object should not be allowed. Imo the latter outweighs the prior.

@johnb432 johnb432 changed the title Cargo - Make all containers hold less cargo than their size as cargo Cargo - Add documentation on adding cargo via config May 9, 2024
@johnb432 johnb432 added kind/documentation ignore-changelog Release Notes: Excluded and removed kind/change Release Notes: **CHANGED:** labels May 9, 2024
@johnb432
Copy link
Contributor Author

johnb432 commented May 9, 2024

More people in were favor of not changing sizes, so PR has been adapted accordingly.

@johnb432 johnb432 added this to the 3.18.0 milestone May 9, 2024
@PabstMirror PabstMirror merged commit db2bf60 into master May 22, 2024
5 checks passed
@PabstMirror PabstMirror deleted the cargo-size-fixes branch May 22, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants