Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle Damage - Add turret tossing again #9989

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Apr 28, 2024
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
@johnb432 johnb432 changed the title Vehicle Damage - Reenable turret tossing Vehicle Damage - Add turret tossing again Apr 28, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone May 9, 2024
@TheCandianVendingMachine
Copy link
Contributor

it was originally disabled because i wanted turret tossing for non setDamage 1 deaths. The issue with this is, you'd be able to repair the vehicle; now without a turret

@johnb432
Copy link
Contributor Author

it was originally disabled because i wanted turret tossing for non setDamage 1 deaths.

I'm confused. What other sorts of death are there?

@TheCandianVendingMachine
Copy link
Contributor

cookoff without catastrophic explosion. it is possible, and any refactoring of AVD will have it if I have anything to say about it

@johnb432
Copy link
Contributor Author

johnb432 commented May 28, 2024

cookoff without catastrophic explosion. it is possible, and any refactoring of AVD will have it if I have anything to say about it

But seeing as not implemented yet, can't we enable turret tossing just for vehicles that are destroyed via the Killed EH?
I'll add a comment in the code with the additional info you provided, so we'd remember it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants