Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle Damage - Fix applying medical damage to non-local and invulnerable units #9988

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Apr 28, 2024

When merged this pull request will:

  • Requires Common - Add setDead API #10045.
  • Fixes medical damage application:
    • It would try damage non-local units, making it fail.
    • It would injure invulnerable units.
    • I've added a new function to address those issues. If medical is not loaded, it will apply vanilla damage to the crew.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Apr 28, 2024
@PabstMirror
Copy link
Contributor

IIRC drivers used to get hit a lot more from damage compared to everyone else and this is probably why
but I also sorta thought that had been fixed?

Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@johnb432
Copy link
Contributor Author

IIRC drivers used to get hit a lot more from damage compared to everyone else and this is probably why but I also sorta thought that had been fixed?

Still is the case before this PR and after. It's not all the time, but sometimes when shooting AP at a Merkava tank, the driver is turned into minced meat (15-45 large wounds per body part).

So technically speaking, the PR's title is misleading, as it doesn't address that part.

@johnb432 johnb432 changed the title Vehicle Damage - Fix applying medical damage to units Vehicle Damage - Fix applying medical damage to non-local and invulnerable units Apr 29, 2024
@johnb432
Copy link
Contributor Author

johnb432 commented Apr 29, 2024

I've updated the PR's title to better reflect the content. Drivers taking insane amounts of damage should be resolved in another PR imo, I want to keep this PR as small as possible.

The problem doesn't stem from here, as medical damage is only applied via calling of medical functions if the vehicle is going to detonate (either because incoming damage is very high or because something critical was hit). When testing, I never had the vehicle detonate.

@johnb432 johnb432 added this to the 3.18.0 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants