Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grenades - Make flashbang detonation sound configurable via config #9985

Merged
merged 5 commits into from
May 22, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Apr 28, 2024
@jonpas jonpas added this to the 3.18.0 milestone Apr 29, 2024
@PabstMirror
Copy link
Contributor

Need to deconflict with #9982

I guess array of arrays?
something like

ace_grenades_flashbangExplodeSound[] = { // Sound that is played upon detonation (file path, volume, pitch, max distance)
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_01.wss", 5, 1.2, 400},
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_02.wss", 5, 1.2, 400}, 
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_03.wss", 5, 1.2, 400},
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_04.wss", 5, 1.2, 400}
};

@johnb432
Copy link
Contributor Author

Need to deconflict with #9982

I guess array of arrays? something like

ace_grenades_flashbangExplodeSound[] = { // Sound that is played upon detonation (file path, volume, pitch, max distance)
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_01.wss", 5, 1.2, 400},
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_02.wss", 5, 1.2, 400}, 
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_03.wss", 5, 1.2, 400},
    {"A3\Sounds_F\arsenal\explosives\grenades\Explosion_HE_grenade_04.wss", 5, 1.2, 400}
};

Imo we don't need to, but it would be more flexible. We could use selectRandom then instead of what is currently being done.
I'll implement the changes.

@johnb432 johnb432 merged commit 67fe22a into master May 22, 2024
5 checks passed
@johnb432 johnb432 deleted the flashbang-sound-config branch May 22, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants