Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build) Redo code coverage reporting, remove istanbul-combine #465

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Oct 19, 2021

Signed-off-by: jeromesimeon jeromesimeon@me.com

Description

Some recent builds are failing due to issues merging code coverage reporting. See e.g., https://github.com/accordproject/markdown-transform/runs/3924510479?check_suite_focus=true

In addition, istanbul-combine is not maintained and has known vulnerabilities.

So I'm finally biting that bullet and re-doing the final code coverage reporting.

This is more painful than expected. One option would be to do a matrix for coveralls in the Github Actions and let coveralls do the merge.

The option chosen here instead is to re-do the code coverage merge using:

  1. a script to copy the files into ./coverage
  2. use the native nyc merge

Changes

Flags

  • Still has to be tested live with the coveralls Github Actions app
  • If working, this change should be made to all repos

Signed-off-by: jeromesimeon <jeromesimeon@me.com>
@coveralls
Copy link

coveralls commented Oct 19, 2021

Coverage Status

Coverage decreased (-0.4%) to 85.525% when pulling f96afe7 on js-fix-coverage into bc167f9 on master.

Signed-off-by: jeromesimeon <jeromesimeon@me.com>
@jeromesimeon jeromesimeon merged commit b2e9a7d into master Oct 19, 2021
@jeromesimeon jeromesimeon deleted the js-fix-coverage branch October 19, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants