Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Github pipelines #6

Closed
wants to merge 15 commits into from

Conversation

hermeswaldemarin
Copy link
Collaborator

No description provided.

@hermeswaldemarin hermeswaldemarin marked this pull request as ready for review November 8, 2023 18:03
steps:
- uses: actions/checkout@v3

- name: Setup Java 17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually setting up java 8

steps:
- uses: actions/checkout@v3

- name: Setup Java 17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

export GPG_TTY=$(tty)
mkdir -p ~/.gradle/
ln -s /usr/local/bin/gpg /usr/local/bin/gpg2
echo -n "$SECRET_FILE_DATA" | base64 --decode | gpg --import --passphrase $ORG_GRADLE_PROJECT_signingInMemoryKeyPassword --batch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo -n "$SECRET_FILE_DATA" | base64 --decode | gpg --import --passphrase $ORG_GRADLE_PROJECT_signingInMemoryKeyPassword --batch
echo -n "$SECRET_FILE_DATA" | base64 --decode | gpg --import --passphrase "$ORG_GRADLE_PROJECT_signingInMemoryKeyPassword" --batch

@@ -8,6 +8,8 @@ description = """ABSmartly Java SDK"""

def httpClientVersion = "5.1.3"

def lombokVersion = "1.18.26"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to use Lombok with old Android versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, when I did it I forgot that was java 1.6 :(. Going to check.

@hermeswaldemarin
Copy link
Collaborator Author

Merged to branch feature/fix-analysis-issues with squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants