Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for YouTube videos, in addition to Strapi gallery #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Srushtika
Copy link
Member

@Srushtika Srushtika commented Jul 1, 2021

YouTube URL support added

@Srushtika Srushtika requested a review from malgamves July 1, 2021 14:16
@malgamves
Copy link
Contributor

The deploy is failing for some reason - this is the error message I see in the logs

4:18:10 PM:   ERROR in ./node_modules/videojs-youtube/node_modules/video.js/dist/video.es.js
4:18:10 PM:   Module not found: Error: Can't resolve 'mux.js/lib/tools/parse-sidx' in 'node_modules/videojs-youtube/node_modules/video.js/dist'
  @ ./node_modules/videojs-youtube/node_modules/video.js/dist/video.es.js 30:0-52 30222:17-26
4:18:10 PM:   @ ./node_modules/videojs-youtube/dist/Youtube.js
4:18:10 PM:   @ ./store/index.js
4:18:10 PM:   @ ./node_modules/.cache/nuxt/store.js
4:18:10 PM:   @ ./node_modules/.cache/nuxt/index.js
4:18:10 PM:   @ ./node_modules/.cache/nuxt/client.js
4:18:10 PM:   @ multi ./node_modules/@nuxt/components/lib/installComponents.js ./node_modules/.cache/nuxt/client.js

looks like an issue with a package. Did you add it to the client package.json?

@Srushtika
Copy link
Member Author

@malgamves looks like the checks have passed. Are you able to check if this is working as expected?

@malgamves
Copy link
Contributor

hey @Srushtika everything looks great! I can't seem to get videos to play when I copy them from Youtube. Is there a format or video type supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants