Use new shutdown procedure #251
Conversation
|
|
||
| This does nothing if no server is running." | ||
| (interactive) | ||
|
|
||
| (unwind-protect |
There was a problem hiding this comment.
Why is unwind-protect used here? There is no unwind forms (2nd parmaeter)?
There was a problem hiding this comment.
Good question. I guess that either a) it's a vestige that can be removed or b) ycmd--global-teardown was supposed to be the unwind form. Maybe it should be (when (ycmd-running?) (unwind-protect (...shutdown...) (ycmd--global-teardown))). But I'm not sure how it got this way...
There was a problem hiding this comment.
Ahhh...I see that's exactly what you've done! ;)
|
I don't have time to really test this right now, but if it works for you then I'm glad to merge it in. |
|
We need to wait here for upstream. They haven't merged it yet in This doesn't work with the current implementation. |
|
Sounds good :) |
|
ycm-core/ycmd#282 was merged 😃 |
|
@vheon Cool! Thanks for letting us know |
|
There is more change needed. The startup process changed and with the new changes from |
ptrv
force-pushed
the
new-shutdown-procedure
branch
from
565e19e
to
c060b24
Compare
ptrv
force-pushed
the
new-shutdown-procedure
branch
from
c060b24
to
7c7c2d3
Compare
|
The server address print has been re-added in ycmd server. |
The ycmd server has now a shutdown handler and we need to send a
shutdown request instead of killing the process.
See ycm-core/ycmd#282
Resolves #240