Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #94 #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #94 #99

wants to merge 2 commits into from

Conversation

RC-Rajat
Copy link

@RC-Rajat RC-Rajat commented Dec 5, 2019

Tried to solve #94 by putting the entire body of code within a try...except block.On keyboard interrupt, The except block displays 'Process Stopped by user'. However,it also gives an Exception and a traceback.To stop that, I redirected stderr to a file 'err.txt'. This makes it such that the user gets a clean response on pressing Ctrl + C.

@RC-Rajat RC-Rajat mentioned this pull request Dec 5, 2019
@RC-Rajat
Copy link
Author

RC-Rajat commented Dec 5, 2019

Sorry,Forgot to remove 'import signal'

@mzfr
Copy link
Collaborator

mzfr commented Dec 7, 2019

@RC-Rajat Thanks for the PR but I don't think putting the entire code in try and catch is the best solution.
We need to handle the threads properly so it would be nice if you can find ways to terminate threads without having to use a dirty approach.

cc: @abhisharma404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants