Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colors in ALV converter + Drawing reference #1105

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

KonstantinKhrushchev
Copy link

@KonstantinKhrushchev KonstantinKhrushchev commented May 6, 2023

Fix #1102
Optimization #1107

@KonstantinKhrushchev KonstantinKhrushchev changed the title Update colors in ALV converter Update colors in ALV converter + Drawing reference May 8, 2023
@larshp
Copy link
Member

larshp commented May 8, 2023

instead of using SAP standard data elements GUID_16 & GUID_32 which are not used in abap2xslsx currently, and also not released. Is it possible to use some of the already existing/used data elements?

@KonstantinKhrushchev
Copy link
Author

change guid_16 -> zexcel_guid, guid_32 -> char32

@KonstantinKhrushchev
Copy link
Author

@larshp thanks for review.
corrected

@darnoc312
Copy link
Contributor

Do you think this is senseful for charts too ?
IF so provide it for charts too, else let it for charts in the previous way (counter).
Currently you have a mix for charts and ZDEMO_EXCEL39 does not work anymore because of not matching rId.

For the moment i included the following in CREATE_XL_DRAWINGS_RELS recovering the field lv_counter so it works again.
lv_counter must be counted always because the while loop in CREATE_XL_DRAWINGS does too.

image

@sandraros
Copy link
Collaborator

@darnoc312 Could you create a new issue and explain exactly what happens with ZDEMO_EXCEL39? (I don't get what means "does not work anymore because of not matching rId"; after that, you can propose a pull request containing your fix, text is always better than screenshot). Concerning the current issue, you can do an advance test in your system to see if the current fix works (pull the commit of the pull request). That will help us if you do a feedback on it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing colours for ALV converter
5 participants