-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable row filters when binding alv #1017
Draft
AndreaBorgia-Abo
wants to merge
15
commits into
abap2xlsx:main
Choose a base branch
from
AndreaBorgia-Abo:fix-bind_no_filter
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
enable row filters when binding alv #1017
AndreaBorgia-Abo
wants to merge
15
commits into
abap2xlsx:main
from
AndreaBorgia-Abo:fix-bind_no_filter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting "filter" option in method BIND_ALV enables filter detection later; this happens in GET_FILTER (ZCL_EXCEL_CONVERTER_ALV) which takes the filter, applies it and returns table "et_filter" with the row numbers of the filtered items.
Removing the milestone for 7.16 since I don't know when I'll be able to work on this and I'd like to release the new version. |
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary work, for feedback:
On the left, the file generated with the simple patch of this PR opening the file in Excel 2019, I can see an autofilter is set for a specific value (42692) in column D (flight date) but does not take effect because of the formatting.
On the right the same autofilter once the file has been re-saved from Excel, after setting the filter for year 2016.
I repeated the test with column S (agency number), same thing: autofilter created but not working because of formatting.
Clearly still some work to do, I'm documenting it here in case anyone has some tips, until I have some more time to dig into this.