Refactor/least core #580
Merged
Refactor/least core #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to make them pass.
…y - rename file to target-name
…y - rename source-file to git-split-temp
…y - resolve conflict and keep both files
…y - restore name of source-file
…ion/methods/_naive_least_core.py - rename file to target-name
…ion/methods/_naive_least_core.py - rename source-file to git-split-temp
…ion/methods/_naive_least_core.py - resolve conflict and keep both files
…ion/methods/_naive_least_core.py - restore name of source-file
…aluation/methods/_montecarlo_least_core.py - rename file to target-name
…aluation/methods/_montecarlo_least_core.py - rename source-file to git-split-temp
…aluation/methods/_montecarlo_least_core.py - resolve conflict and keep both files
…aluation/methods/_montecarlo_least_core.py - restore name of source-file
…/test_sampler.py - resolve conflict and keep both files
…/test_sampler.py - restore name of source-file
…/methods/test_least_core_valuation.py - rename file to target-name
…/methods/test_least_core_valuation.py - rename source-file to git-split-temp
…/methods/test_least_core_valuation.py - resolve conflict and keep both files
…/methods/test_least_core_valuation.py - restore name of source-file
schroedk
requested changes
May 22, 2024
…ing for n_samples.
schroedk
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the least-core to make use of the new samplers in
pydvl.valuation. The previously supported least-core methods are now just special cases: "exact" is obtained using aDeterministicUniformSampler; "montecarlo" is obtained using aUniformSampler.Changes
Complete rewrite of the least-core code in
pydvl.valuation. The old code remains unchanged inpydvl.valueChecklist
"tags": ["hide"]or"tags": ["hide-input"]