Replace transition with css animation #903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would solve a problem that can happen, especially if the images already have a transition effect applied. With animation the style is applied in a specific time frame without interfering with the css style. it's a small modification I know, but it can make everything more beautiful (or less glitchy). Thanks for your script it's very useful to me!
small changes to meet the standard and a fix - missing opacity: 1 on the background while the image is loading - replaced spaces with tabs - restored the original value of .3s for the animation (personally I prefer .1s though)
this way there is even less chance of flickering for images to which opacity has been applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would solve a problem that can happen, especially if the images already have a transition effect applied. With animation the style is applied in a specific time frame without interfering with the css style.
it's a small modification I know, but it can make everything more beautiful (or less glitchy). Thanks for your script it's very useful to me!