Fix card focus edge cases #1265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmason
added
styling
boring-cyborg
bot
added
javascript
mxmason
force-pushed
the
fix/card-focus-edge-cases
branch
from
5daf364
to
d733a4e
Compare
mxmason
removed
javascript
|
I am not able to reproduce #1208 anymore after @ericwbailey refactored the card resources. Can you tell me the steps to reproduce so I can verify that it's fixed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1208
Summary
This PR addresses an edge case in the way we style
:focus-withinon the resource cards: if the user focused within a card and then clicked outside the browser window, the card title would turn black, while the rest of the text remained white.