Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ml dataset #232

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Fix ml dataset #232

wants to merge 8 commits into from

Conversation

kamurani
Copy link
Contributor

@kamurani kamurani commented Nov 5, 2022

Fixed some issues in the ProteinGraphDataset class, such as

  • checking for bad uniprot IDs for alphafold structure download (believe this was also fixed by @a-r-j in another func with try: except ?)
  • check that graph construction succeeded, otherwise None object will be passed to convertor function and create ValueError
  • fixed up indexing in distance.py (this was from a while back, not sure if it's been fixed elsewhere already)

@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
6.1% 6.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamurani @a-r-j