use short arguments in install script #1158 #1159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix for #1158
In some machines, there is an issue with installation scripts.
For example on some mac we get error:
and
This comes from:
cut --delimiter='/' --fields=3 | tail --lines=1This is due to the versions of cut and tail installed on different systems. For example https://ss64.com/osx/cut.html
To solve the issue, we should replace the long name of parameters with shorthands like -d instead of --delimeter, -f instead of --fields, -n instead of --lines
- How to verify it
You can test it by running install.sh script
- Description for the changelog
support different releases of cut and tail in install.sh