An attemp to update to 1.20.6 #355
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <div align="center"> | |||
|
|
|||
| <a href=""></a> | |||
| <a href=""></a> | |||
There was a problem hiding this comment.
Is the Java version bump necessary?
There was a problem hiding this comment.
Is the Java version bump necessary?
1.20.5 and newer versions require Java 21
Read this for more info: https://www.minecraft.net/en-us/article/minecraft-java-edition-1-20-5
And also this for most of the breaking changes:
https://fabricmc.net/2024/04/19/1205.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sent a PR for updating to 1.20.4 and it seems to be working, but this require more work because of more breaking changes
The goal of this PR is to update the mod so it work with 1.20.5 since there are some breaking changes
And I will try to update it with care, so when require java 21 as minimum because of 1.20.5, it's also updated in
README.md, in GitHub CI and also in all the other placesif there is something I'm not sure about or something doesn't look right (Unreachable code that is already before this update for example) I will always leave a
TODOso we can look to them laterFor now forge doesn't support 1.20.5/6 so to not cause build failure I temporarily disable it, also player animator dependency mod (I might send a PR right after this) has not updated to 1.20.5 yet
This PR might be closed and never finished since I'm not familiar with the Minecraft Apis and also not with this repository, and also player animator dependency has not updated to 1.20.5/6 yet