Nbt multiplayer fixes #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so, this is a weird one.
NBT based properties are fully broken on servers.
This is because Attribute Containers were never synced to the client, only the finished WeaponAttributes
This means a player that never joined single player has no Attribute Container and this client is unable to locally resolve the nbt correctly.
To replicate this issue, simply open a server, start the client fresh, dont join single player, join directly a server and use
/give @p minecraft:wooden_sword{weapon_attributes:'{"parent":"bettercombat:claymore"}'} 1This wooden sword wont have any animations.
If one enters singleplayer and then back to the server the same sword will work.
This PR fixes this issue by also syncing the Attribute Container in the same packet as the Weapon Attributes.