Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19.2-compatible with replay mod. #323

Open
wants to merge 1 commit into
base: 1.19.2
Choose a base branch
from

Conversation

Arcomit
Copy link

@Arcomit Arcomit commented Jan 17, 2024

In single-player mode, the replay mod cannot record player actions because the replay mod only stores packets. Therefore, packets have been added for the client player. These packets do not affect the game in progress and only apply to the replay.

@Arcomit
Copy link
Author

Arcomit commented Jan 17, 2024

Ah… sorry, I just noticed that someone has done similar work to mine.
But this implementation should have good compatibility.
Because PlayerLookup.tracking can’t get the player itself, I manually send packets for the player again.
This packet sending will not have any effect on the game (in ClientNetwork Class, entity != MinecraftClient.getInstance().player), and replay will record this packet. Also, during the replay playback, the recorded player will not be identified as the same player as the current client player, so it will take effect.

@Smartin-b Smartin-b mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant