Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigData: default to not checking for updated versions of ZoneMinder #3825

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davvid
Copy link
Contributor

@davvid davvid commented Feb 10, 2024

Users should get updates through the package.
Also prevents "phoning home" to zoneminder.com.

Users should get updates through the package. Also prevents "phoning
home" to zoneminder.com.
@davvid
Copy link
Contributor Author

davvid commented Feb 10, 2024

The first patch in this series originated from Debian's patches:
https://salsa.debian.org/debian/zoneminder/-/tree/master/debian/patches?ref_type=heads

@davvid davvid force-pushed the debian/disable-update-checks-by-default branch from c774b4c to eca0076 Compare February 10, 2024 22:52
@SteveGilvarry
Copy link
Member

SteveGilvarry commented Feb 10, 2024 via email

@davvid
Copy link
Contributor Author

davvid commented Feb 10, 2024

Thanks for the pointer @SteveGilvarry much appreciated. I mostly submitted this patch because I agree with Debian's position that the tool should be privacy-respecting by default (for all users) rather than something that's Debian-only. This isn't really a big deal for Debian since they're already patching it, but it seemed worth sharing in case y'all agree.

We can close this PR if maintainers feel otherwise, though. It's all good. Thanks again for zoneminder.

@connortechnology
Copy link
Member

The problem here is that people do not manually check for updates. We still have people using ZoneMinder from 10 years ago, that we know are completely insecure and broken.

We agree with the general stance of respecting privacy, but we also want people to get updates. So since distros manage the updates, that's cool that they disable this. For anyone else, I think we should stick with it enabled. Now, it probably SHOULD be a bigger, more in your face decision to make upon first install, like the telemetry configuration.

I would certainly merge a PR that did that in addition to this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants