Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/masp #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Murisi/masp #32

wants to merge 5 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Feb 19, 2024

Implemented the parsing of MASP Transactions and Builders. Some notes:

  • The code was generated by running a C parser generator on the following Borsh schema: masp_borsh_schema.txt . The format's documentation can be found here.
  • The generator calls mem_alloc to support parsing variable length arrays, but this dependency should be easily removable if upper bounds can be established on the vectors occurring in the serializations.
  • More types of Namada addresses can now be parsed including internal Ethereum addresses. Full parsing of addresses is required to be able to decode AssetTypes.
  • The test vectors have been temporarily filtered to include only MASP transactions since that is the focus of this branch. However it should still support all test vectors from Ledger app v0.0.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant