Feat/add ton jettons #26
Open
+1,161
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
commented
Apr 30, 2024
Comment on lines
+91
to
+108
| const op: TonOperation = { | ||
| id: "", | ||
| hash: "", | ||
| type: "OUT", | ||
| senders: [address], | ||
| recipients: [recipient], | ||
| accountId, | ||
| value, | ||
| fee: fees, | ||
| blockHash: null, | ||
| blockHeight: null, | ||
| date: new Date(), | ||
| extra: { | ||
| // we don't know yet, will be patched in final operation | ||
| lt: "", | ||
| explorerHash: "", | ||
| comment: comment, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Whenever we do a token transfer, this tx does not really exists. I think there is a type "Fee" that you could use instead of OUT, as it is not really an OUT tx, but fees payment
There was a problem hiding this comment.
mm yes, you are right Emma! I'll add it
| const subAccount = findSubAccountById(a, t.subAccountId || ""); | ||
|
|
||
| const amount = subAccount | ||
| ? toNano("0.05") // for commission fees, excess will be returned |
There was a problem hiding this comment.
Can we make this a constant somewhere, to make it clear what this value is?
There was a problem hiding this comment.
I don't find a good name for the constant. What do you think about maxComissionTokenTransferFee? @emmanuelm41
* The id and hash will be empty, because it will be replaced in broadcast * Adjust the body of the token transfer * Replace getSubAccount to findSubAccountById (an existent function)
ayelenmurano
force-pushed
the
feat/add-ton-jettons
branch
from
11f60a9
to
102dbc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
❓ Context
🧐 Checklist for the PR Reviewers