added cancellation to createZipFileAtPath #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes are purely additive, no former API has been changed. |
|
@ZipArchive/collaborators I guess none of us is actively maintaining this repo anymore, since this PR is more than 2 years old. If anyone is seeing this message and is interested in maintaining ziparchive, kindly offer a review to this PR, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createZipFileAtPath does not provide a way to cancel a long running archive creation process. This patch adds a 'shouldStop' handler to some of the createZipFileAtPath* methods. If the handler returns YES, the creation process is stopped and a failure is returned.