Make eth_getTransactionCount respect the pending block number
#861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrw-zilliqa
previously approved these changes
Apr 23, 2024
theo-zil
previously approved these changes
Apr 24, 2024
JamesHinshelwood
dismissed stale reviews from theo-zil and rrw-zilliqa
via
35229c6
When the block number is `pending`, we also count the transactions in the mempool.
JamesHinshelwood
force-pushed
the
count-pending
branch
from
35229c6
to
1e18193
Compare
rrw-zilliqa
approved these changes
May 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the block number is
pending, we also count the transactions in the mempool.