Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GetBlockchainInfo #845

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Implement GetBlockchainInfo #845

merged 1 commit into from
Apr 23, 2024

Conversation

JamesHinshelwood
Copy link
Contributor

@JamesHinshelwood JamesHinshelwood commented Apr 17, 2024 •
edited

I left a bunch of the fields at 0 because calculating them is hard and requires us to store extra data. #860 tracks fixing them.

@JamesHinshelwood
Copy link
Contributor Author

Review after #843.

@JamesHinshelwood JamesHinshelwood marked this pull request as draft April 17, 2024 12:00
auto-merge was automatically disabled April 17, 2024 12:00

Pull request was converted to draft

@JamesHinshelwood JamesHinshelwood changed the base branch from main to get-tx-block April 17, 2024 12:01
@JamesHinshelwood JamesHinshelwood force-pushed the get-tx-block branch 2 times, most recently from 73b1c1f to cc0e4b4 Compare April 19, 2024 11:34
Base automatically changed from get-tx-block to main April 19, 2024 14:12
@JamesHinshelwood JamesHinshelwood marked this pull request as ready for review April 23, 2024 17:57
rrw-zilliqa
rrw-zilliqa approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@rrw-zilliqa rrw-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - at least it's better than the previous implementation.

@JamesHinshelwood JamesHinshelwood added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 3b3e398 Apr 23, 2024
4 checks passed
@JamesHinshelwood JamesHinshelwood deleted the blockchain-info branch April 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrw-zilliqa rrw-zilliqa rrw-zilliqa approved these changes

@bzawisto bzawisto Awaiting requested review from bzawisto

@theo-zil theo-zil Awaiting requested review from theo-zil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamesHinshelwood @rrw-zilliqa