Make Scilla compatible with Zilliqa 2 #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We add another binary which exposes the `scilla-server` JSON-RPC interface over HTTP. * The state IPC calls now make requests over HTTP, rather than via a unix domain socket. Note that this is a breaking change, meaning this version of Scilla will NOT work with Zilliqa 1. * All bytes in IPC calls are encoded into base64. Previously, we would include invalid UTF-8 strings in JSON-RPC requests, which resulted in invalid JSON.
rrw-zilliqa
approved these changes
Apr 11, 2024
| @@ -119,9 +120,9 @@ FROM ubuntu:22.04 | |||
|
|
|||
| RUN apt-get update -y \ | |||
| && apt-get install -y build-essential \ | |||
| libev-dev \ | |||
There was a problem hiding this comment.
One of the dependencies needed it - I didn't dig any further than that. If its a concern I can? 🤷♂️
| let response = Caml.input_line ic in | ||
| Core_unix.close socket; | ||
| DebugMessage.plog (Printf.sprintf "Response: %s\n" response); | ||
| print_endline (Printf.sprintf "Sending: %s\n" msg_buf); |
There was a problem hiding this comment.
Make this conditional? The more we print, the slower stuff gets :-(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scilla-serverJSON-RPC interface over HTTP.