Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook to remove cursors. #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xslendix
Copy link
Collaborator

This PR adds a pre-commit hook specifically for *NIX systems to remove the cursor byte from all files under src/.

The reason why I chose python is because it is assumed that most *NIX systems already come with it pre-installed.

Copy link
Collaborator

@Midnoclose Midnoclose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I believe that the cursor should be removed by Zeal during the sync script so as to not rely on a python dependency.

@xslendix
Copy link
Collaborator Author

It does not rely on a Python dependency if the contributor doesn't want to use the actual hook. This is totally optional. I mean you need to install the hook after all with the appropriate hook.

@Midnoclose Midnoclose added the enhancement New feature or request label Feb 25, 2023
This patch adds a pre-commit hook specifically for *NIX systems to
remove the cursor byte from all files under `src/`.

The reason why I chose python is because it is assumed that most *NIX
systems already come with it pre-installed.

Signed-off-by: xSlendiX <slendi@socopon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants