Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyprus motorway shields #558

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Cyprus motorway shields #558

wants to merge 7 commits into from

Conversation

1ec5
Copy link
Collaborator

@1ec5 1ec5 commented Oct 9, 2022

Added a shield definition for A roads (motorways) in Cyprus, as well as Akrotiri and Dhekelia, a British Overseas Territory. So far only A roads have been mapped; B roads (main roads) and E roads (secondary roads) don’t have relations yet.

larnaca

dhekalia

@1ec5 1ec5 self-assigned this Oct 9, 2022
@1ec5 1ec5 added this to In progress in Shield internationalization via automation Oct 9, 2022
@@ -3062,6 +3062,16 @@ export function loadShields(shieldImages) {
Color.shields.white
);

// Cyprus
shields["cy:national"] = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

national is an unusual name for what seems to be a network of motorways. cy:motorway would be more appropriate, as would cy:A-road considering the A prefix.

It's unclear whether this tagging was invented by a Cypriot. Is there a Cyprus OSM community that we can contact about this?

Copy link
Collaborator Author

@1ec5 1ec5 Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Wikipedia, “motorway” is equivalent to the A-road network, but it does sound like B-roads and E-roads could also be part of a national numbering scheme. Maybe this was an attempt to conform to what was perceived as international terminology (not the first time I’ve seen it). The tag was introduced in changeset 44730739.

The community index doesn’t list any local community for Cyprus, and the national tagging page doesn’t provide any guidance on route relations.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to solidify a tagging scheme that may complicate tagging guidelines for the remaining route networks in Cyprus. It's unclear how other networks in Cyprus should be tagged if we decide to support cy:national.

Cyprus is a small country, and the mapping community may only be a few people. Perhaps we could ask the Greek community for their perspective—certainly some of them would be familiar with Cyprus, and if there are any Cypriot mappers, there's a chance we may find them there.

@claysmalley

This comment was marked as resolved.

@1ec5 1ec5 moved this from In progress to Waiting for community response in Shield internationalization Nov 26, 2022
@ZeLonewolf
Copy link
Owner

How should we proceed on this? Is it worth proposing a route network scheme for Cyprus and advertise it in the appropriate channels, and implement it if there's no objections?

@claysmalley
Copy link
Collaborator

How should we proceed on this? Is it worth proposing a route network scheme for Cyprus and advertise it in the appropriate channels, and implement it if there's no objections?

Sounds like a plan.

@1ec5 By the way, the hexagonal icons can be replaced with the new draw functions here.

@ZeLonewolf
Copy link
Owner

What would be a sane scheme for A, B, and E roads?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for community response
Shield internationalization
Waiting for community response
Development

Successfully merging this pull request may close these issues.

None yet

3 participants