Add Costa Rica shields #458
Conversation
|
Route 10111? Is that a real route? |
|
Yeah, though it might should be |
src/js/shield_defs.js
Outdated
| @@ -551,6 +565,9 @@ export function loadShields(shieldImages) { | |||
| // Yukon | |||
| shields["CA:YT"] = roundedRectShield(Color.shields.white, Color.shields.red); | |||
|
|
|||
| // Costa Rica | |||
| shields["CR:national"] = badgeWithStrokeShield; | |||
There was a problem hiding this comment.
network=CR:national is being tagged on every route in the National Road Network, making no distinctions between primary, secondary, and tertiary routes, even though all three classes have different shields. This is similar to the situation in #455 (comment).
network=CR:national está aplicado en cada ruta de la Red Vial Nacional, sin distinción entre las rutas primarias, secundarias, y terciarias, aunque las tres clasificaciones tienen los señales diferentes. Es similar con la situación en #455 (comment).
There was a problem hiding this comment.
This sounds like a showstopper, right? Don't we have a similar situation in a country in Europe?
There was a problem hiding this comment.
Yeah, I think so. We must be able to determine shield appearance from network=*, and three different route shields are all assigned network=CR:national. This would need to be fixed before we can support Costa Rican shields.
There was a problem hiding this comment.
claysmalley
added
blocked
mapping
claysmalley
force-pushed
the
shields-costa-rica
branch
from
6fcf7e5
to
d79a56f
Compare
|
Given the lack of response, I'd say someone could simply define a sensible scheme for Costa Rica's road system. Note that this PR has to get updated to handle the new shape drawing functions. |
Initial support for shields of Costa Rica.