Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃懟 Cemeteries #329

Draft
wants to merge 42 commits into
base: main
Choose a base branch
from
Draft

馃懟 Cemeteries #329

wants to merge 42 commits into from

Conversation

ZeLonewolf
Copy link
Owner

@ZeLonewolf ZeLonewolf commented May 17, 2022

This is an initial implementation of cemetery rendering. Starting this as draft so folks can play with it as we don't have an agreement on the styling yet. This implementation uses the same fill and stroke as parks, and adds a grave POI icon. However, based on the initial slack discussion, there is a preference towards rendering cemeteries in a color distinct from parks.

image

image

Location: https://www.openstreetmap.org/relation/8551292
image

@jeisenbe
Copy link

jeisenbe commented Jun 8, 2022

The tombstone icon is very strong. I don鈥檛 see many icons like that in the current deployment. In Openstreetmap Carto there is a repeating pattern across the area, and it changes it based on the religion of the cemetery, rather than showing an icon next to the name. A similar idea is also used in Opencyclemap and CyclOSM.

Most cemeteries are mapped as areas so an icon is not needed by the name if the area rendering is understandable. I would recommend using a different color, not the same as parks.

@1ec5
Copy link
Collaborator

1ec5 commented Jun 8, 2022

Below are the cemetery treatments I found in my map collection, previously posted in the Slack thread linked above. In the future, let鈥檚 open a separate issue for features we want to render so we can more easily discuss the possibilities independently of a particular implementation.

岷h ch峄 M脿n h矛nh 2022-05-16 l煤c 18 55 51 岷h ch峄 M脿n h矛nh 2022-05-16 l煤c 18 57 52 岷h ch峄 M脿n h矛nh 2022-05-16 l煤c 18 58 55 岷h ch峄 M脿n h矛nh 2022-05-16 l煤c 18 59 35 岷h ch峄 M脿n h矛nh 2022-05-16 l煤c 19 00 06 岷h ch峄 M脿n h矛nh 2022-05-16 l煤c 19 00 48

Depending on the publisher, I鈥檝e seen a green fill matching parks or something more drab; a repeating religious symbol pattern, or a solid fill juxtaposed with a tree cover鈥搇ike pattern for parks.

The icon is probably only necessary at low and mid zoom levels where the label has the potential to overflow outside the bounds of the cemetery, making the location less obvious. In most maps that symbolize cemeteries with icons at smaller scales, the icon is a religious symbol matching the symbol for a place of worship, or it鈥檚 just a square or dot matching any other POI.

Arlington National Cemetery demonstrates the need for the vector tiles to represent cemetery sectors differently than cemeteries. Currently, they鈥檙e tagged as nested landuse=cemetery areas, which is unfortunate. One approach that openstreetmap-carto seems to accommodate well is nested amenity=grave_yard areas, though OpenMapTiles conflates these tags. The proposed cemetery=sector tag isn鈥檛 supported, but that鈥檚 probably the best outcome for now.

@ZeLonewolf
Copy link
Owner Author

I don鈥檛 see many icons like that in the current deployment

At the moment, we don't have any POIs rendered, so the map is effectively blank of icons, with the exception of places and highway shields. I'm working behind the scenes to set up the infrastructure for POI icons with recolorable SDFs in an efficient way but that's a bit off. So I wouldn't consider the lack of other icons to be a stylistic choice but rather an indicator of incompletion.

it changes it based on the religion of the cemetery

Religion tagging is not available in OpenMapTiles. This is not a deal-breaker if we decide we want to render it, but if we do, we would either have to get it added to OpenMapTiles or else render a custom layer (for example using the new customizability feature implemented in onthegomap/planetiler#160) and get it hosted somewhere. If we do want religion-specific tagging rendered, we'll probably want something generic to render as a temporary measure until the tagging can get added to the tiles.

@jeisenbe
Copy link

jeisenbe commented Jun 9, 2022

Religion tagging is not available in OpenMapTiles

In that case, a solid color without a pattern would be fine.

@ZeLonewolf
Copy link
Owner Author

Blocked by #387

@ZeLonewolf
Copy link
Owner Author

The infrastructure is now in place for POIs, however, no icons in the "green" class have been implemented yet.

@ZeLonewolf
Copy link
Owner Author

Updated imagery showing potential differentiated park/cemetery rendering:

image

I'm finding that if I darken the colors too much, it clashes with cased roads.

@ZeLonewolf ZeLonewolf mentioned this pull request Jan 15, 2023
@github-actions
Copy link

PR Preview:

Sprite Sheets:

Sprites 1x
Sprites 2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants