chore: bump @vue/cli-shared-utils #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made a node>=18 version for temporary use if anyone else has this problem, as the maintainers seem busy atm: https://www.npmjs.com/package/nx-plus-vue-node-18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Trying to install
@nx-plus/vuefails with:on node >= 18. This is because
@vue/cli-shared-utilshard relies on version9.2.2of@achrinza/node-ipcwhich only supports node < 18.Expected Behavior
@nx-plus/vueshould install on node >= 18 without errors.Fixes
Unfortunately, the newest 4.x version of
@vue/cli-shared-utilsalso hard relies onnode-ipc@9.2.2. So I bumped the shared utils package to5.0.8. I couldn't get the e2e tests to work (even without this change), but the unit tests go through. If the maintainers think that the package should stay on 4.x I can create a similiar PR on@vue/cli-shared-utilsto bump node-ipc instead.