Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add postinstall instructions to Vite and Nuxt READMEs #254

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bokub
Copy link
Contributor

@bokub bokub commented May 18, 2022

  • Add the "Nx dependency graph" paragraph to Vite and Nuxt READMEs (they were missing)
  • Create a binary alias so the postinstall script is shorter in the package.json (the old command still works 馃檪 )

Copy link
Owner

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are updating the documentation to point to the binary, we should update the schematics to use the binary over the node script. Let me know if you need any help with that!

libs/nuxt/README.md Outdated Show resolved Hide resolved
@bokub
Copy link
Contributor Author

bokub commented May 18, 2022

Since we are updating the documentation to point to the binary, we should update the schematics to use the binary over the node script. Let me know if you need any help with that!

Sorry but I don't understand what you mean

@bokub bokub force-pushed the docs/post-install-script branch from 1af7880 to 69bba83 Compare May 18, 2022 16:36
@ZachJW34
Copy link
Owner

When we scaffold a new application, we will add this post-install script if it is not already there. You can see that here (and in the other packages, I need to make some reusable libs). The binary script looks better, so we should update the generators to add the binary script vs the node script.

@bokub
Copy link
Contributor Author

bokub commented May 18, 2022

Oh OK, got it. I'll try to do that tomorrow 馃憤

@bokub
Copy link
Contributor Author

bokub commented May 19, 2022

@ZachJW34 Done 鉁旓笍

@bokub
Copy link
Contributor Author

bokub commented May 19, 2022

I have no idea why the tests are failing in CircleCI, they are not failing locally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants