Update README.md #242
Open
Update README.md #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolveConfigureWebpack is an async function that returns the promise of the require statement. But all of the locations where resolveConfigureWebpack was called, were not awaited. This meant that users of the plugin were not able to install their own webpack configuration because the contents of configure-webpack.js was never actually read and added to the vue-cli configuration object. This commit adds the awaits for all of the locations where the function is called. Unfortunately there are no unit tests that test these functions and I didn't know how to go about adding unit tests for this area. So there are no new tests for this change. However, I believe it is important to get this out to users of the plugin quickly because without this change the plugin is virtually useless for any substantial vue app.
I have added information to the Readme file of the vue plugin that I wish was there before I started migrating my app into Nx with the vue plugin. Knowing this information up front could have saved me days of time spent searching and getting things wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added information to the Readme file of the vue plugin that I wish was there before I started migrating my app into Nx with the vue plugin. Knowing this information up front could have saved me days of time spent searching and getting things wrong.