Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User registration backend #1682

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

User registration backend #1682

wants to merge 3 commits into from

Conversation

tituspijean
Copy link
Contributor

@tituspijean tituspijean commented Jun 26, 2023 •
edited

Disclaimer: only technical discussions are allowed in the comments. 🛠️

Addresses some parts of YunoHost/issues#1677.
Will depend on other PRs in SSOwat and the webadmin.

  • configuration panel for registration modes (discarding user-to-user mode suggested by users for the time being)
  • actionsmap
    • deviation from the initial plan: add endpoints to list, create, delete invitation codes (to manage the suggested nb_account number of accounts that can be create by an invitation code)
    • deviation from the initial plan: split CAPTCHA (GET) and register (POST) endpoints
    • decide if we let users decide their domain for main email address and xmpp account
    • decide if we let users decide their login shell (IMHO it's poweruser level, let's default it)
  • Python functions:
    • user_subscription_list()
    • user_subscription_accept()
    • user_subscription_deny()
    • user_subscription_invite_list()
    • user_subscription_invite_create()
    • user_subscription_invite_delete()
    • user_subscription_captcha() (help needed, I have no idea how to implement that)
    • user_subscription_register()
    • user_subscription_resend()
    • user_subscription_validate()
  • cron to clean old validation/invitation codes
  • log for Fail2Ban to prevent brute-force attempts on the invitation codes

PR Status

Much drafty.

How to test

Don't.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 29, 2023
View reviewed changes
src/user.py
@@ -25,10 +25,15 @@
import string
import subprocess
import copy
import yaml

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'yaml' is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depends on other PR
Projects
None yet
Milestone
No milestone
1 participant
@tituspijean