Fix issue #205 #206
Open
Fix issue #205 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for a `prompt=` configuration flag with a custom prompt. If not specified, existing prompt/behavior is used.
|
One note on this is that specifying a prompt with more than one printf character (%s) can/would cause problems/crashes. In my opinion we just need to clarify this in the README as there's no valid use-case for that behavior |
|
Thanks for your interest here. I'd like to see this changed to put a default value in cfg->prompt and not have to do conditions every time it's used. You could do this by putting the default template in a const char* and have the cfg pointer default to that. Also please make sure that this functionality is called into by the tests in tests/pam_test.c Don't forget manpage docs for pam_yubico.8.txt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
prompt=configuration flag with a custom prompt. If not specified, existing prompt/behavior is used.