-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new introduction for the new Elementor editor #21388
Merged
vraja-pro
merged 6 commits into
trunk
from
217-adapt-yoast-seo-for-elementor-notification-to-elementor-top-bar-navigation
May 21, 2024
Merged
Create a new introduction for the new Elementor editor #21388
vraja-pro
merged 6 commits into
trunk
from
217-adapt-yoast-seo-for-elementor-notification-to-elementor-top-bar-navigation
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s at first, old and new
leonidasmi
added
the
changelog: enhancement
Needs to be included in the 'Enhancements' category in the changelog
label
May 16, 2024
…ion-to-elementor-top-bar-navigation
enricobattocchi
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR & Acc ✅
waiting for a check from @igorschoester or @vraja-pro
CR & ACC ✅ |
vraja-pro
deleted the
217-adapt-yoast-seo-for-elementor-notification-to-elementor-top-bar-navigation
branch
May 21, 2024 08:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Editor Top Bar
to activeGot it
button, confirm that the modal disappears and after a refresh, confirm that it doesn't appear againelementor_introduction
usermeta of your user and delete itRelevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Editor Top Bar
setting todefault
orInactive
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/reserved-tasks/issues/217