Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make travis build succeed with node 12.13.0 #13691

Closed
IreneStr opened this issue Oct 22, 2019 · 1 comment · Fixed by #13899
Closed

Make travis build succeed with node 12.13.0 #13691

IreneStr opened this issue Oct 22, 2019 · 1 comment · Fixed by #13899
Assignees

Comments

@IreneStr
Copy link
Contributor

IreneStr commented Oct 22, 2019

In the .travis.yml, we used to specify the usage of the lts version of node. However, the Travis builds started failing when Travis started using node 12.13.0 instead of 10.16.3 as lts version. Therefore, in #13690 we hardcoded the node version to 10.16.

However, this is not a longterm solution. 10.16 also has the LTS status until April 2020, but after that, 12.13 will be the LTS version.

These are my findings thus far:

NB. The same errors also appear locally if you upgrade to node 12.13.

Related issues:
https://github.com/Yoast/wordpress-seo-premium/issues/2591
Yoast/javascript#383

@atimmer
Copy link
Contributor

atimmer commented Nov 13, 2019

This has since been fixed for Yoast/javascript: Yoast/javascript#390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants