Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

Make travis build succeed with node 12.13.0 #383

Open
IreneStr opened this issue Oct 22, 2019 · 0 comments
Open

Make travis build succeed with node 12.13.0 #383

IreneStr opened this issue Oct 22, 2019 · 0 comments

Comments

@IreneStr
Copy link
Contributor

IreneStr commented Oct 22, 2019

In the .travis.yml, we used to specify the usage of the lts version of node. However, the Travis builds started failing when Travis started using node 12.13.0 instead of 10.16.3 as lts version. Therefore, in #382 we hardcoded the node version to 10.16.

However, this is not a longterm solution. 10.16 also has the LTS status until April 2020, but after that, 12.13 will be the LTS version.

These are my findings thus far:

NB. The same errors also appear locally if you upgrade to node 12.13.

Related issues:
Yoast/wordpress-seo#13691
https://github.com/Yoast/wordpress-seo-premium/issues/2591

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant